Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3826721 authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] iscsi class, iscsi drivers: remove unused iscsi_transport attrs 



max_cmd_len and max_conn are not really used. max_cmd_len is
always 16 and can be set by the LLD. max_conn is always one
since we do not support MCS.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 40753caa

drivers/infiniband/ulp/iser/iscsi_iser.c

+0 −1
Original line number Diff line number Diff line
@@ -592,7 +592,6 @@ static struct iscsi_transport iscsi_iser_transport = { 
	.host_template          = &iscsi_iser_sht,

	.conndata_size		= sizeof(struct iscsi_conn),

	.max_lun                = ISCSI_ISER_MAX_LUN,

	.max_cmd_len            = ISCSI_ISER_MAX_CMD_LEN,

	/* session management */

	.create_session         = iscsi_iser_session_create,

	.destroy_session        = iscsi_session_teardown,

drivers/infiniband/ulp/iser/iscsi_iser.h

+0 −1
Original line number Diff line number Diff line
@@ -96,7 +96,6 @@ 
					/* support upto 512KB in one RDMA */

#define ISCSI_ISER_SG_TABLESIZE         (0x80000 >> SHIFT_4K)

#define ISCSI_ISER_MAX_LUN		256

#define ISCSI_ISER_MAX_CMD_LEN		16



/* QP settings */

/* Maximal bounds on received asynchronous PDUs */

drivers/scsi/iscsi_tcp.c

+0 −2
Original line number Diff line number Diff line
@@ -1978,8 +1978,6 @@ static struct iscsi_transport iscsi_tcp_transport = { 
				  ISCSI_HOST_NETDEV_NAME,

	.host_template		= &iscsi_sht,

	.conndata_size		= sizeof(struct iscsi_conn),

	.max_conn		= 1,

	.max_cmd_len		= 16,

	/* session management */

	.create_session		= iscsi_tcp_session_create,

	.destroy_session	= iscsi_tcp_session_destroy,

drivers/scsi/libiscsi.c

+1 −1
Original line number Diff line number Diff line
@@ -1830,7 +1830,7 @@ iscsi_session_setup(struct iscsi_transport *iscsit, 
	shost->max_id = 1;

	shost->max_channel = 0;

	shost->max_lun = iscsit->max_lun;

	shost->max_cmd_len = iscsit->max_cmd_len;

	shost->max_cmd_len = 16;

	shost->transportt = scsit;

	shost->transportt->create_work_queue = 1;

	shost->transportt->eh_timed_out = iscsi_eh_cmd_timed_out;

drivers/scsi/scsi_transport_iscsi.c

+0 −4
Original line number Diff line number Diff line
@@ -102,15 +102,11 @@ static DEVICE_ATTR(name, S_IRUGO, show_transport_##name, NULL); 


show_transport_attr(caps, "0x%x");

show_transport_attr(max_lun, "%d");

show_transport_attr(max_conn, "%d");

show_transport_attr(max_cmd_len, "%d");



static struct attribute *iscsi_transport_attrs[] = {

	&dev_attr_handle.attr,

	&dev_attr_caps.attr,

	&dev_attr_max_lun.attr,

	&dev_attr_max_conn.attr,

	&dev_attr_max_cmd_len.attr,

	NULL,

};