Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d37e2a15 authored by Markus Elfring's avatar Markus Elfring Committed by Daniel Vetter
Browse files

drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked() 



The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/b66399ed-278b-b85d-4a21-b34164936ef6@users.sourceforge.net
parent d3ae2550

drivers/gpu/drm/rockchip/rockchip_drm_fb.c

+2 −6
Original line number Diff line number Diff line
@@ -43,14 +43,10 @@ struct drm_gem_object *rockchip_fb_get_gem_obj(struct drm_framebuffer *fb, 
static void rockchip_drm_fb_destroy(struct drm_framebuffer *fb)

{

	struct rockchip_drm_fb *rockchip_fb = to_rockchip_fb(fb);

	struct drm_gem_object *obj;

	int i;



	for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++) {

		obj = rockchip_fb->obj[i];

		if (obj)

			drm_gem_object_unreference_unlocked(obj);

	}

	for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++)

		drm_gem_object_unreference_unlocked(rockchip_fb->obj[i]);



	drm_framebuffer_cleanup(fb);

	kfree(rockchip_fb);