Commit d34add05 authored Feb 11, 2015 by Christian Engelmayer Committed by Greg Kroah-Hartman Mar 06, 2015

staging: vt6656: Fix possible leak in vnt_download_firmware()

When failing to allocate buffer memory, function vnt_download_firmware() goes
through the wrong exit path and fails to release the already requested
firmware. Thus use the correct cleanup. Detected by Coverity CID 1269128.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6498613d

drivers/staging/vt6656/firmware.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -61,7 +61,7 @@ int vnt_download_firmware(struct vnt_private *priv)

		buffer = kmalloc(FIRMWARE_CHUNK_SIZE, GFP_KERNEL);
		if (!buffer)
		goto out;
		goto free_fw;

		for (ii = 0; ii < fw->size; ii += FIRMWARE_CHUNK_SIZE) {
		length = min_t(int, fw->size - ii, FIRMWARE_CHUNK_SIZE);