Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2d76b8d authored by Benjamin Li's avatar Benjamin Li Committed by Jeff Garzik
Browse files

qla3xxx: Remove unnecessary memset() in qla3xxx_send() 



We do not need to zero out the 64 byte MAC request I/O control block.
  By zeroing out the control block and setting it to proper fields is
redundant work.  This is because in the qla3xxx_send() function we will
already set the proper fields in this structure.  The unused fields are
not looked at by the hardware and do not need to be zeroed out.

Signed-off-by: default avatarBenjamin Li <benjamin.li@qlogic.com>
Signed-off-by: default avatarRon Mercer <ron.mercer@qlogic.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 546faf07

drivers/net/qla3xxx.c

+0 −1
Original line number Diff line number Diff line
@@ -2188,7 +2188,6 @@ static int ql3xxx_send(struct sk_buff *skb, struct net_device *ndev) 


	}

	mac_iocb_ptr = tx_cb->queue_entry;

	memset((void *)mac_iocb_ptr, 0, sizeof(struct ob_mac_iocb_req));

	mac_iocb_ptr->opcode = qdev->mac_ob_opcode;

	mac_iocb_ptr->flags |= qdev->mb_bit_mask;

	mac_iocb_ptr->transaction_id = qdev->req_producer_index;