Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2cbb83c authored by Jon Derrick's avatar Jon Derrick Committed by Greg Kroah-Hartman
Browse files

iommu: Remove device link to group on failure 



commit 7d4e6ccd1fb09dbfbc49746ca82bd5c25ad4bfe4 upstream.

This adds the missing teardown step that removes the device link from
the group when the device addition fails.

Signed-off-by: default avatarJon Derrick <jonathan.derrick@intel.com>
Fixes: 797a8b4d ("iommu: Handle default domain attach failure")
Reviewed-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 44ce3acf

drivers/iommu/iommu.c

+1 −0
Original line number Diff line number Diff line
@@ -650,6 +650,7 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev) 
	mutex_unlock(&group->mutex);

	dev->iommu_group = NULL;

	kobject_put(group->devices_kobj);

	sysfs_remove_link(group->devices_kobj, device->name);

err_free_name:

	kfree(device->name);

err_remove_link: