Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2c184fb authored by Dan Carpenter's avatar Dan Carpenter Committed by Dave Airlie
Browse files

vmwgfx: return -EFAULT instead of number of bytes remaining 



The intent here was to return an error code, but instead the code
returns the number of bytes remaining (that weren't copied).

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent bd8315c4

drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c

+2 −0
Original line number Diff line number Diff line
@@ -150,6 +150,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data, 
	ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));

	if (ret) {

		DRM_ERROR("Failed to copy clip rects from userspace.\n");

		ret = -EFAULT;

		goto out_no_copy;

	}
@@ -241,6 +242,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data, 
	ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));

	if (ret) {

		DRM_ERROR("Failed to copy clip rects from userspace.\n");

		ret = -EFAULT;

		goto out_no_copy;

	}