Commit d29d4ccc authored Dec 25, 2018 by Kangjie Lu Committed by Greg Kroah-Hartman Dec 05, 2019

net: stmicro: fix a missing check of clk_prepare



[ Upstream commit f86a3b83833e7cfe558ca4d70b64ebc48903efec ]

clk_prepare() could fail, so let's check its status, and if it fails,
return its error code upstream.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7d751914

drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -59,7 +59,9 @@ static int sun7i_gmac_init(struct platform_device pdev, void priv)
		gmac->clk_enabled = 1;
		} else {
		clk_set_rate(gmac->tx_clk, SUN7I_GMAC_MII_RATE);
		clk_prepare(gmac->tx_clk);
		ret = clk_prepare(gmac->tx_clk);
		if (ret)
		return ret;
		}

		return 0;