Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d28fb1ff authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: sm750fb: fix a type issue in sm750_set_chip_type() 



"revId" needs to be unsigned because we use it to test:

	if (revId == SM750LE_REVISION_ID) {

and SM750LE_REVISION_ID is ((unsigned char )0xfe).

Fixes: 81dee67e ("staging: sm750fb: add sm750 to staging")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4e0447cd

drivers/staging/sm750fb/ddk750_chip.c

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ logical_chip_type_t sm750_get_chip_type(void) 
	return chip;

}



void sm750_set_chip_type(unsigned short devId, char revId)

void sm750_set_chip_type(unsigned short devId, u8 revId)

{

	if (devId == 0x718)

		chip = SM718;

drivers/staging/sm750fb/ddk750_chip.h

+1 −1
Original line number Diff line number Diff line
@@ -87,7 +87,7 @@ struct initchip_param { 
};



logical_chip_type_t sm750_get_chip_type(void);

void sm750_set_chip_type(unsigned short devId, char revId);

void sm750_set_chip_type(unsigned short devId, u8 revId);

unsigned int sm750_calc_pll_value(unsigned int request, struct  pll_value *pll);

unsigned int sm750_format_pll_reg(struct pll_value *pPLL);

unsigned int ddk750_get_vm_size(void);