Commit d22749b6 authored Jan 18, 2006 by J. Bruce Fields Committed by Linus Torvalds Jan 18, 2006

[PATCH] nfsd4: fix open of recovery directory



We should be opening this directory RDONLY, not RDWR.

Thanks to Christoph Hellwig for the bug report.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 5fb8b49e

fs/nfsd/nfs4recover.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -222,8 +222,7 @@ nfsd4_list_rec_dir(struct dentry dir, recdir_func f)

		nfs4_save_user(&uid, &gid);

		filp = dentry_open(dget(dir), mntget(rec_dir.mnt),
		O_RDWR);
		filp = dentry_open(dget(dir), mntget(rec_dir.mnt), O_RDONLY);
		status = PTR_ERR(filp);
		if (IS_ERR(filp))
		goto out;