Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d21c95c5 authored by Jonathan Corbet's avatar Jonathan Corbet
Browse files

Add "no BKL needed" comments to several drivers 



This documents the fact that somebody looked at the relevant open()
functions and concluded that, due to their trivial nature, no locking was
needed.

Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
parent 39d95b9d

arch/cris/arch-v10/drivers/eeprom.c

+1 −1
Original line number Diff line number Diff line
@@ -375,7 +375,7 @@ int __init eeprom_init(void) 
}



/* Opens the device. */



/* BKL not needed: no global resources accessed */

static int eeprom_open(struct inode * inode, struct file * file)

{

arch/cris/arch-v32/drivers/cryptocop.c

+1 −1
Original line number Diff line number Diff line
@@ -2302,7 +2302,7 @@ static int cryptocop_job_setup(struct cryptocop_prio_job **pj, struct cryptocop_ 
	return 0;

}





/* No BKL needed here - no global resources accessed */

static int cryptocop_open(struct inode *inode, struct file *filp)

{

	int p = iminor(inode);

drivers/char/cs5535_gpio.c

+2 −0
Original line number Diff line number Diff line
@@ -153,6 +153,8 @@ static ssize_t cs5535_gpio_read(struct file *file, char __user *buf, 
	return count;

}



/* No BKL needed here - "mask" is the only global resource used

   here and it's a boot-time parameter */

static int cs5535_gpio_open(struct inode *inode, struct file *file)

{

	u32 m = iminor(inode);

drivers/char/dtlk.c

+2 −0
Original line number Diff line number Diff line
@@ -288,6 +288,8 @@ static int dtlk_ioctl(struct inode *inode, 
	}

}



/* No BKL needed here; "dtlk_busy" is the only global resource,

   and it is not ever set by anybody (test is broken) */

static int dtlk_open(struct inode *inode, struct file *file)

{

	TRACE_TEXT("(dtlk_open");

drivers/char/pc8736x_gpio.c

+1 −0
Original line number Diff line number Diff line
@@ -212,6 +212,7 @@ static struct nsc_gpio_ops pc8736x_gpio_ops = { 
	.gpio_current	= pc8736x_gpio_current

};



/* No BKL needed here; no global resources accessed */

static int pc8736x_gpio_open(struct inode *inode, struct file *file)

{

	unsigned m = iminor(inode);