Commit d2083d0e authored Oct 30, 2017 by Pan Bian Committed by David S. Miller Nov 01, 2017

net: hns: set correct return value



The function of_parse_phandle() returns a NULL pointer if it cannot
resolve a phandle property to a device_node pointer. In function
hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract
the error code. However, in this case, the extracted error code will
always be zero, which is unexpected.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7db8874a

drivers/net/ethernet/hisilicon/hns/hns_enet.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2369,8 +2369,8 @@ static int hns_nic_dev_probe(struct platform_device *pdev)
		priv->enet_ver = AE_VERSION_2;

		ae_node = of_parse_phandle(dev->of_node, "ae-handle", 0);
		if (IS_ERR_OR_NULL(ae_node)) {
		ret = PTR_ERR(ae_node);
		if (!ae_node) {
		ret = -ENODEV;
		dev_err(dev, "not find ae-handle\n");
		goto out_read_prop_fail;
		}