Commit d1a3a036 authored Aug 23, 2016 by Matthew Auld Committed by Joonas Lahtinen Aug 24, 2016

drm/i915: free intel_fb

We need to free the allocated intel_fb in the error path, not
intel_fb->base. Otherwise we risk calling kfree with a non-kmalloc'd
address, which is bound to give us grief at some point.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1471964444-24460-1-git-send-email-matthew.auld@intel.com

parent 8f76aa0e

drivers/gpu/drm/i915/intel_display.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -9777,7 +9777,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
	return;		return;

	error:		error:
	kfree(fb);		kfree(intel_fb);
	}		}

	static void ironlake_get_pfit_config(struct intel_crtc *crtc,		static void ironlake_get_pfit_config(struct intel_crtc *crtc,