Commit d197f798 authored Jul 31, 2017 by Matthias Kaehlcke Committed by Daniel Lezcano Aug 10, 2017

clocksource/drivers/arm_arch_timer: Fix mem frame loop initialization



The loop to find the best memory frame in arch_timer_mem_acpi_init()
initializes the loop counter with itself ('i = i'), which is suspicious
in the first place and pointed out by clang. The loop condition is
'i < timer_count' and a prior for loop exits when 'i' reaches
'timer_count', therefore the second loop is never executed.

Initialize the loop counter with 0 to iterate over all timers, which
supposedly was the intention before the typo monster attacked.

Fixes: c2743a36 ("clocksource: arm_arch_timer: add GTDT support for memory-mapped timer")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

parent 34f41c03

drivers/clocksource/arm_arch_timer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1440,7 +1440,7 @@ static int __init arch_timer_mem_acpi_init(int platform_timer_count)
		* While unlikely, it's theoretically possible that none of the frames
		* in a timer expose the combination of feature we want.
		*/
		for (i = i; i < timer_count; i++) {
		for (i = 0; i < timer_count; i++) {
		timer = &timers[i];

		frame = arch_timer_mem_find_best_frame(timer);