Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0eca719 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Felipe Balbi
Browse files

usb: gadget: phonet: free requests in pn_bind()'s error path 



Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 7f2a9268

drivers/usb/gadget/f_phonet.c

+6 −2
Original line number Diff line number Diff line
@@ -531,7 +531,7 @@ int pn_bind(struct usb_configuration *c, struct usb_function *f) 


		req = usb_ep_alloc_request(fp->out_ep, GFP_KERNEL);

		if (!req)

			goto err;

			goto err_req;



		req->complete = pn_rx_complete;

		fp->out_reqv[i] = req;
@@ -540,14 +540,18 @@ int pn_bind(struct usb_configuration *c, struct usb_function *f) 
	/* Outgoing USB requests */

	fp->in_req = usb_ep_alloc_request(fp->in_ep, GFP_KERNEL);

	if (!fp->in_req)

		goto err;

		goto err_req;



	INFO(cdev, "USB CDC Phonet function\n");

	INFO(cdev, "using %s, OUT %s, IN %s\n", cdev->gadget->name,

		fp->out_ep->name, fp->in_ep->name);

	return 0;



err_req:

	for (i = 0; i < phonet_rxq_size && fp->out_reqv[i]; i++)

		usb_ep_free_request(fp->out_ep, fp->out_reqv[i]);

err:



	if (fp->out_ep)

		fp->out_ep->driver_data = NULL;

	if (fp->in_ep)