Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d06d101b authored by Dhaval Shah's avatar Dhaval Shah Committed by Greg Kroah-Hartman
Browse files

misc: ad525x_dpot: Prefer 'unsigned int' to bare use of 'unsigned' 



Resolved all the Prefer 'unsigned int' to bare use of 'unsigned'
checkpatch warnings. Issue found by checkpatch.

Signed-off-by: default avatarDhaval Shah <dhaval.shah@softnautics.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ef7e69fc

drivers/misc/ad525x_dpot.c

+11 −11
Original line number Original line Diff line number Diff line
@@ -84,12 +84,12 @@ 
struct dpot_data {

struct dpot_data {

	struct ad_dpot_bus_data	bdata;

	struct ad_dpot_bus_data	bdata;

	struct mutex update_lock;

	struct mutex update_lock;

	unsigned rdac_mask;

	unsigned int rdac_mask;

	unsigned max_pos;

	unsigned int max_pos;

	unsigned long devid;

	unsigned long devid;

	unsigned uid;

	unsigned int uid;

	unsigned feat;

	unsigned int feat;

	unsigned wipers;

	unsigned int wipers;

	u16 rdac_cache[MAX_RDACS];

	u16 rdac_cache[MAX_RDACS];

	DECLARE_BITMAP(otp_en_mask, MAX_RDACS);

	DECLARE_BITMAP(otp_en_mask, MAX_RDACS);

};

};
@@ -126,7 +126,7 @@ static inline int dpot_write_r8d16(struct dpot_data *dpot, u8 reg, u16 val) 




static s32 dpot_read_spi(struct dpot_data *dpot, u8 reg)

static s32 dpot_read_spi(struct dpot_data *dpot, u8 reg)

{

{

	unsigned ctrl = 0;

	unsigned int ctrl = 0;

	int value;

	int value;





	if (!(reg & (DPOT_ADDR_EEPROM | DPOT_ADDR_CMD))) {

	if (!(reg & (DPOT_ADDR_EEPROM | DPOT_ADDR_CMD))) {
@@ -175,7 +175,7 @@ static s32 dpot_read_spi(struct dpot_data *dpot, u8 reg) 
static s32 dpot_read_i2c(struct dpot_data *dpot, u8 reg)

static s32 dpot_read_i2c(struct dpot_data *dpot, u8 reg)

{

{

	int value;

	int value;

	unsigned ctrl = 0;

	unsigned int ctrl = 0;





	switch (dpot->uid) {

	switch (dpot->uid) {

	case DPOT_UID(AD5246_ID):

	case DPOT_UID(AD5246_ID):
@@ -238,7 +238,7 @@ static s32 dpot_read(struct dpot_data *dpot, u8 reg) 




static s32 dpot_write_spi(struct dpot_data *dpot, u8 reg, u16 value)

static s32 dpot_write_spi(struct dpot_data *dpot, u8 reg, u16 value)

{

{

	unsigned val = 0;

	unsigned int val = 0;





	if (!(reg & (DPOT_ADDR_EEPROM | DPOT_ADDR_CMD | DPOT_ADDR_OTP))) {

	if (!(reg & (DPOT_ADDR_EEPROM | DPOT_ADDR_CMD | DPOT_ADDR_OTP))) {

		if (dpot->feat & F_RDACS_WONLY)

		if (dpot->feat & F_RDACS_WONLY)
@@ -328,7 +328,7 @@ static s32 dpot_write_spi(struct dpot_data *dpot, u8 reg, u16 value) 
static s32 dpot_write_i2c(struct dpot_data *dpot, u8 reg, u16 value)

static s32 dpot_write_i2c(struct dpot_data *dpot, u8 reg, u16 value)

{

{

	/* Only write the instruction byte for certain commands */

	/* Only write the instruction byte for certain commands */

	unsigned tmp = 0, ctrl = 0;

	unsigned int tmp = 0, ctrl = 0;





	switch (dpot->uid) {

	switch (dpot->uid) {

	case DPOT_UID(AD5246_ID):

	case DPOT_UID(AD5246_ID):
@@ -636,7 +636,7 @@ static const struct attribute_group ad525x_group_commands = { 
};

};





static int ad_dpot_add_files(struct device *dev,

static int ad_dpot_add_files(struct device *dev,

		unsigned features, unsigned rdac)

		unsigned int features, unsigned int rdac)

{

{

	int err = sysfs_create_file(&dev->kobj,

	int err = sysfs_create_file(&dev->kobj,

		dpot_attrib_wipers[rdac]);

		dpot_attrib_wipers[rdac]);
@@ -661,7 +661,7 @@ static int ad_dpot_add_files(struct device *dev, 
}

}





static inline void ad_dpot_remove_files(struct device *dev,

static inline void ad_dpot_remove_files(struct device *dev,

		unsigned features, unsigned rdac)

		unsigned int features, unsigned int rdac)

{

{

	sysfs_remove_file(&dev->kobj,

	sysfs_remove_file(&dev->kobj,

		dpot_attrib_wipers[rdac]);

		dpot_attrib_wipers[rdac]);