Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0593c36 authored by Wolfram Sang's avatar Wolfram Sang Committed by Geert Uytterhoeven
Browse files

pinctrl: sh-pfc: Propagate errors on group config 



On group configuration, bail out if setting one of the individual pins
fails. We don't need to roll-back, the pinctrl core will do this for us.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent 5771a8c0

drivers/pinctrl/sh-pfc/pinctrl.c

+6 −3
Original line number Diff line number Diff line
@@ -742,13 +742,16 @@ static int sh_pfc_pinconf_group_set(struct pinctrl_dev *pctldev, unsigned group, 
	struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);

	const unsigned int *pins;

	unsigned int num_pins;

	unsigned int i;

	unsigned int i, ret;



	pins = pmx->pfc->info->groups[group].pins;

	num_pins = pmx->pfc->info->groups[group].nr_pins;



	for (i = 0; i < num_pins; ++i)

		sh_pfc_pinconf_set(pctldev, pins[i], configs, num_configs);

	for (i = 0; i < num_pins; ++i) {

		ret = sh_pfc_pinconf_set(pctldev, pins[i], configs, num_configs);

		if (ret)

			return ret;

	}



	return 0;

}