Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0439a54 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

hangcheck-timer: cleanup casting in hangcheck_init() 



The 32 bit addition "(hangcheck_margin + hangcheck_tick)" could
potentially overflow.  It triggers a static checker warning to have an
overflowed addition followed by a no-op cast.  I have moved the cast so
that the addition can't overflow.

Also I removed the unneeded cast on the following line since both
"hangcheck_tsc_margin" and "TIMER_FREQ" are already 64 bit types.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d2522152

drivers/char/hangcheck-timer.c

+2 −2
Original line number Diff line number Diff line
@@ -168,8 +168,8 @@ static int __init hangcheck_init(void) 
	printk("Hangcheck: starting hangcheck timer %s (tick is %d seconds, margin is %d seconds).\n",

	       VERSION_STR, hangcheck_tick, hangcheck_margin);

	hangcheck_tsc_margin =

		(unsigned long long)(hangcheck_margin + hangcheck_tick);

	hangcheck_tsc_margin *= (unsigned long long)TIMER_FREQ;

		(unsigned long long)hangcheck_margin + hangcheck_tick;

	hangcheck_tsc_margin *= TIMER_FREQ;



	hangcheck_tsc = ktime_get_ns();

	mod_timer(&hangcheck_ticktock, jiffies + (hangcheck_tick*HZ));