Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d03c3593 authored by Thomas Abraham's avatar Thomas Abraham Committed by Kukjin Kim
Browse files

ARM: EXYNOS4: fix incorrect pad configuration for keypad row lines 



The keypad controller requires a external pull-up for all the keypad
row lines. Fix the incorrect pad configuration for keypad controller
row lines by enabling the pad pull-up for the all row lines of the
keypad controller.

Signed-off-by: default avatarThomas Abraham <thomas.abraham@linaro.org>
Signed-off-by: default avatarKukjin Kim <kgene.kim@samsung.com>
parent 3a0ec259

arch/arm/mach-exynos4/setup-keypad.c

+6 −5
Original line number Diff line number Diff line
@@ -19,15 +19,16 @@ void samsung_keypad_cfg_gpio(unsigned int rows, unsigned int cols) 


	if (rows > 8) {

		/* Set all the necessary GPX2 pins: KP_ROW[0~7] */

		s3c_gpio_cfgrange_nopull(EXYNOS4_GPX2(0), 8, S3C_GPIO_SFN(3));

		s3c_gpio_cfgall_range(EXYNOS4_GPX2(0), 8, S3C_GPIO_SFN(3),

					S3C_GPIO_PULL_UP);



		/* Set all the necessary GPX3 pins: KP_ROW[8~] */

		s3c_gpio_cfgrange_nopull(EXYNOS4_GPX3(0), (rows - 8),

					 S3C_GPIO_SFN(3));

		s3c_gpio_cfgall_range(EXYNOS4_GPX3(0), (rows - 8),

					 S3C_GPIO_SFN(3), S3C_GPIO_PULL_UP);

	} else {

		/* Set all the necessary GPX2 pins: KP_ROW[x] */

		s3c_gpio_cfgrange_nopull(EXYNOS4_GPX2(0), rows,

					 S3C_GPIO_SFN(3));

		s3c_gpio_cfgall_range(EXYNOS4_GPX2(0), rows, S3C_GPIO_SFN(3),

					S3C_GPIO_PULL_UP);

	}



	/* Set all the necessary GPX1 pins to special-function 3: KP_COL[x] */