Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d03b29a2 authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Al Viro
Browse files

namei: trivial fix to vfs_rename_dir comment 



Looks like the directory loop check is actually done in renameat?
Whatever, leave this out rather than trying to keep it up to date with
the code.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent b8faf035

fs/namei.c

+1 −1
Original line number Diff line number Diff line
@@ -4024,7 +4024,7 @@ SYSCALL_DEFINE2(link, const char __user *, oldname, const char __user *, newname 
 * The worst of all namespace operations - renaming directory. "Perverted"

 * doesn't even start to describe it. Somebody in UCB had a heck of a trip...

 * Problems:

 *	a) we can get into loop creation. Check is done in is_subdir().

 *	a) we can get into loop creation.

 *	b) race potential - two innocent renames can create a loop together.

 *	   That's where 4.4 screws up. Current fix: serialization on

 *	   sb->s_vfs_rename_mutex. We might be more accurate, but that's another