Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0088775 authored by Dave Airlie's avatar Dave Airlie
Browse files

drm/i915: check the return value from the copy from user 



This produced a warning on my build, not sure why super-warning-man didn't
notice this one, its much worse than the %z one.

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 90f959bc

drivers/gpu/drm/i915/i915_gem.c

+4 −1
Original line number Diff line number Diff line
@@ -446,13 +446,16 @@ fast_shmem_write(struct page **pages, 
		 int length)

{

	char __iomem *vaddr;

	unsigned long unwritten;



	vaddr = kmap_atomic(pages[page_base >> PAGE_SHIFT], KM_USER0);

	if (vaddr == NULL)

		return -ENOMEM;

	__copy_from_user_inatomic(vaddr + page_offset, data, length);

	unwritten = __copy_from_user_inatomic(vaddr + page_offset, data, length);

	kunmap_atomic(vaddr, KM_USER0);



	if (unwritten)

		return -EFAULT;

	return 0;

}