Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfe2b621 authored by Bart Van Assche's avatar Bart Van Assche Committed by Nicholas Bellinger
Browse files

target/iscsi: Fix a race condition in iscsit_add_reject_from_cmd() 



Avoid that cmd->se_cmd.se_tfo is read after a command has already been
freed.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Mike Christie <mchristi@redhat.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent e1dfb21f

drivers/target/iscsi/iscsi_target.c

+2 −1
Original line number Diff line number Diff line
@@ -833,6 +833,7 @@ static int iscsit_add_reject_from_cmd( 
	unsigned char *buf)

{

	struct iscsi_conn *conn;

	const bool do_put = cmd->se_cmd.se_tfo != NULL;



	if (!cmd->conn) {

		pr_err("cmd->conn is NULL for ITT: 0x%08x\n",
@@ -863,7 +864,7 @@ static int iscsit_add_reject_from_cmd( 
	 * Perform the kref_put now if se_cmd has already been setup by

	 * scsit_setup_scsi_cmd()

	 */

	if (cmd->se_cmd.se_tfo != NULL) {

	if (do_put) {

		pr_debug("iscsi reject: calling target_put_sess_cmd >>>>>>\n");

		target_put_sess_cmd(&cmd->se_cmd);

	}