Commit cfda2794 authored Aug 25, 2014 by Alexander Usyskin Committed by Greg Kroah-Hartman Sep 23, 2014

mei: bus: fix possible boundaries violation



function 'strncpy' will fill whole buffer 'id.name' of fixed size (32)
with string value and will not leave place for NULL-terminator.
Possible buffer boundaries violation in following string operations.
Replace strncpy with strlcpy.

Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 154eb18f

drivers/misc/mei/bus.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -70,7 +70,7 @@ static int mei_cl_device_probe(struct device *dev)

		dev_dbg(dev, "Device probe\n");

		strncpy(id.name, dev_name(dev), sizeof(id.name));
		strlcpy(id.name, dev_name(dev), sizeof(id.name));

		return driver->probe(device, &id);
		}