Commit cf991de2 authored Jun 04, 2015 by Andy Lutomirski Committed by Ingo Molnar Jun 05, 2015

x86/asm/msr: Make wrmsrl_safe() a function



The wrmsrl_safe macro performs invalid shifts if the value
argument is 32 bits.  This makes it unnecessarily awkward to
write code that puts an unsigned long into an MSR.

Convert it to a real inline function.

For inspiration, see:

  7c74d5b7 ("x86/asm/entry/64: Fix MSR_IA32_SYSENTER_CS MSR value").

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
[ Applied small improvements. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 00398a00

arch/x86/include/asm/msr.h

+7 −2

Original line number	Diff line number	Diff line
		@@ -205,8 +205,13 @@ do { \

		#endif /* !CONFIG_PARAVIRT */

		#define wrmsrl_safe(msr, val) wrmsr_safe((msr), (u32)(val), \
		(u32)((val) >> 32))
		/*
		* 64-bit version of wrmsr_safe():
		*/
		static inline int wrmsrl_safe(u32 msr, u64 val)
		{
		return wrmsr_safe(msr, (u32)val, (u32)(val >> 32));
		}

		#define write_tsc(low, high) wrmsr(MSR_IA32_TSC, (low), (high))