Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cecd8d81 authored by Prasad Kanneganti's avatar Prasad Kanneganti Committed by David S. Miller
Browse files

liquidio: avoid doing useless work 



Avoid doing useless work by making sure that the response_list is not empty
before scheduling work to process it.

Signed-off-by: default avatarPrasad Kanneganti <prasad.kanneganti@cavium.com>
Signed-off-by: default avatarFelix Manlunas <felix.manlunas@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fcbedd0f

drivers/net/ethernet/cavium/liquidio/request_manager.c

+5 −0
Original line number Diff line number Diff line
@@ -366,6 +366,7 @@ int 
lio_process_iq_request_list(struct octeon_device *oct,

			    struct octeon_instr_queue *iq, u32 napi_budget)

{

	struct cavium_wq *cwq = &oct->dma_comp_wq;

	int reqtype;

	void *buf;

	u32 old = iq->flush_index;
@@ -450,6 +451,10 @@ lio_process_iq_request_list(struct octeon_device *oct, 
						   bytes_compl);

	iq->flush_index = old;



	if (atomic_read(&oct->response_list

			[OCTEON_ORDERED_SC_LIST].pending_req_count))

		queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(1));



	return inst_count;

}

drivers/net/ethernet/cavium/liquidio/response_manager.c

+4 −2
Original line number Diff line number Diff line
@@ -49,7 +49,6 @@ int octeon_setup_response_list(struct octeon_device *oct) 
	INIT_DELAYED_WORK(&cwq->wk.work, oct_poll_req_completion);

	cwq->wk.ctxptr = oct;

	oct->cmd_resp_state = OCT_DRV_ONLINE;

	queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(50));



	return ret;

}
@@ -164,5 +163,8 @@ static void oct_poll_req_completion(struct work_struct *work) 
	struct cavium_wq *cwq = &oct->dma_comp_wq;



	lio_process_ordered_list(oct, 0);

	queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(50));



	if (atomic_read(&oct->response_list

			[OCTEON_ORDERED_SC_LIST].pending_req_count))

		queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(1));

}