Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce5b615b authored by Daeseok Youn's avatar Daeseok Youn Committed by Greg Kroah-Hartman
Browse files

staging: dgap: fix "if" statement that always evaluates to true 



cppcheck warning:
(warnning) Logical disjunction always evaluates to true

Reported-by: default avatarDavid Binderman <dcb314@hotmail.com>
Signed-off-by: default avatarDaeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed208436

drivers/staging/dgap/dgap.c

+4 −4
Original line number Diff line number Diff line
@@ -978,8 +978,8 @@ static int dgap_parsefile(char **in) 
				brd->u.board.conc1++;



			conc_type = dgap_gettok(in);

			if (conc_type == 0 || conc_type != CX ||

			    conc_type != EPC) {

			if (conc_type == 0 || (conc_type != CX &&

			    conc_type != EPC)) {

				pr_err("failed to set a type of concentratros");

				return -1;

			}
@@ -1019,8 +1019,8 @@ static int dgap_parsefile(char **in) 
				brd->u.board.module1++;



			module_type = dgap_gettok(in);

			if (module_type == 0 || module_type != PORTS ||

			    module_type != MODEM) {

			if (module_type == 0 || (module_type != PORTS &&

			    module_type != MODEM)) {

				pr_err("failed to set a type of module");

				return -1;

			}