Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce2b885c authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller
Browse files

qede: Reload on GRO changes 



Since driver is using a FW-based GRO implementation, this has some
effects on its ability to cope with GRO enablement/disablement.
As a result, driver must perform an inner-reload as a result of a state
change in the offload configuration of said feature.

[Failure to do so means network stack would continue to receive
aggregated packets even though user requested the feature to be disabled].

Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent be7b6d64

drivers/net/ethernet/qlogic/qede/qede_main.c

+24 −0
Original line number Diff line number Diff line
@@ -2091,6 +2091,29 @@ static void qede_vlan_mark_nonconfigured(struct qede_dev *edev) 
	edev->accept_any_vlan = false;

}



int qede_set_features(struct net_device *dev, netdev_features_t features)

{

	struct qede_dev *edev = netdev_priv(dev);

	netdev_features_t changes = features ^ dev->features;

	bool need_reload = false;



	/* No action needed if hardware GRO is disabled during driver load */

	if (changes & NETIF_F_GRO) {

		if (dev->features & NETIF_F_GRO)

			need_reload = !edev->gro_disable;

		else

			need_reload = edev->gro_disable;

	}



	if (need_reload && netif_running(edev->ndev)) {

		dev->features = features;

		qede_reload(edev, NULL, NULL);

		return 1;

	}



	return 0;

}



#ifdef CONFIG_QEDE_VXLAN

static void qede_add_vxlan_port(struct net_device *dev,

				sa_family_t sa_family, __be16 port)
@@ -2175,6 +2198,7 @@ static const struct net_device_ops qede_netdev_ops = { 
#endif

	.ndo_vlan_rx_add_vid = qede_vlan_rx_add_vid,

	.ndo_vlan_rx_kill_vid = qede_vlan_rx_kill_vid,

	.ndo_set_features = qede_set_features,

	.ndo_get_stats64 = qede_get_stats64,

#ifdef CONFIG_QED_SRIOV

	.ndo_set_vf_link_state = qede_set_vf_link_state,