Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cdddc28a authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Greg Kroah-Hartman
Browse files

Staging: crystalhd: Fix assignment of 0/1 to bool variables 

Convert 0 to false and 1 to true when assigning values to bool
variables. Inspired by commit 3db1cd5c.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/

):

@@
bool b;
@@
(
-b = 0
+b = false
|
-b = 1
+b = true
)

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 11f9c321

drivers/staging/crystalhd/crystalhd_hw.c

+4 −4
Original line number Diff line number Diff line
@@ -1517,7 +1517,7 @@ static void crystalhd_rx_isr(struct crystalhd_hw *hw, uint32_t intr_sts) 
	uint32_t i, list_avail = 0;

	enum BC_STATUS comp_sts = BC_STS_NO_DATA;

	uint32_t y_err_sts, uv_err_sts, y_dn_sz = 0, uv_dn_sz = 0;

	bool ret = 0;

	bool ret = false;



	if (!hw) {

		BCMLOG_ERR("Invalid Arguments\n");
@@ -1852,7 +1852,7 @@ bool crystalhd_hw_interrupt(struct crystalhd_adp *adp, struct crystalhd_hw *hw) 
{

	uint32_t intr_sts = 0;

	uint32_t deco_intr = 0;

	bool rc = 0;

	bool rc = false;



	if (!adp || !hw->dev_started)

		return rc;
@@ -1865,7 +1865,7 @@ bool crystalhd_hw_interrupt(struct crystalhd_adp *adp, struct crystalhd_hw *hw) 


	if (intr_sts) {

		/* let system know we processed interrupt..*/

		rc = 1;

		rc = true;

		hw->stats.dev_interrupts++;

	}
@@ -1886,7 +1886,7 @@ bool crystalhd_hw_interrupt(struct crystalhd_adp *adp, struct crystalhd_hw *hw) 
		/* FIXME: jarod: No udelay? might this be

		 the real reason mini pci-e cards were stalling out? */

		bc_dec_reg_wr(adp, Stream2Host_Intr_Sts, 0);

		rc = 1;

		rc = true;

	}



	/* Rx interrupts */