Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd61d473 authored by Luis Chamberlain's avatar Luis Chamberlain Committed by Greg Kroah-Hartman
Browse files

selftests: firmware: fix verify_reqs() return value 



commit 344c0152d878922365464b7140c74c2a5e073d99 upstream.

commit a6a9be92 ("selftests: firmware: return Kselftest Skip code
for skipped tests") by Shuah modified failures to return the special
error code of $ksft_skip (4). We have a corner case issue where we
*do* want to verify_reqs().

Cc: <stable@vger.kernel.org> # >= 4.18
Fixes: a6a9be92 ("selftests: firmware: return Kselftest Skip code for for skipped tests")
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9765ec7f

tools/testing/selftests/firmware/fw_lib.sh

+1 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ verify_reqs() 
	if [ "$TEST_REQS_FW_SYSFS_FALLBACK" = "yes" ]; then

		if [ ! "$HAS_FW_LOADER_USER_HELPER" = "yes" ]; then

			echo "usermode helper disabled so ignoring test"

			exit $ksft_skip

			exit 0

		fi

	fi

}