Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd4cd565 authored by Ira Weiny's avatar Ira Weiny Committed by Doug Ledford
Browse files

IB/mad: Fix compare between big endian and cpu endian 



The define OPA_LID_PERMISSIVE is big endian and was compared to the
cpu endian variable opa_drslid.

Problem caught by 0-day build infrastructure.

Fixes: 8e4349d1 (IB/mad: Add final OPA MAD processing)
Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: default avatarJohn, Jubin <jubin.john@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 4139032b

drivers/infiniband/core/mad.c

+1 −1
Original line number Diff line number Diff line
@@ -795,7 +795,7 @@ static int handle_outgoing_dr_smp(struct ib_mad_agent_private *mad_agent_priv, 
			goto out;

		}

		opa_drslid = be32_to_cpu(opa_smp->route.dr.dr_slid);

		if (opa_drslid != OPA_LID_PERMISSIVE &&

		if (opa_drslid != be32_to_cpu(OPA_LID_PERMISSIVE) &&

		    opa_drslid & 0xffff0000) {

			ret = -EINVAL;

			dev_err(&device->dev, "OPA Invalid dr_slid 0x%x\n",