Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd141eee authored by David S. Miller's avatar David S. Miller
Browse files

isdn: hysdn: Kill (partially buggy) CVS regision log reporting. 



Some cases try to modify const strings, and in any event the
CVS revision strings have not changed in over ten years making
these printouts completely worthless.

Just kill all of this stuff off.

Reported-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 69e6ed18

drivers/isdn/hysdn/hysdn_defs.h

+0 −2
Original line number Diff line number Diff line
@@ -227,7 +227,6 @@ extern hysdn_card *card_root; /* pointer to first card */ 
/*************************/

/* im/exported functions */

/*************************/

extern char *hysdn_getrev(const char *);



/* hysdn_procconf.c */

extern int hysdn_procconf_init(void);	/* init proc config filesys */
@@ -259,7 +258,6 @@ extern int hysdn_tx_cfgline(hysdn_card *, unsigned char *, 


/* hysdn_net.c */

extern unsigned int hynet_enable; 

extern char *hysdn_net_revision;

extern int hysdn_net_create(hysdn_card *);	/* create a new net device */

extern int hysdn_net_release(hysdn_card *);	/* delete the device */

extern char *hysdn_net_getname(hysdn_card *);	/* get name of net interface */

drivers/isdn/hysdn/hysdn_init.c

+1 −25
Original line number Diff line number Diff line
@@ -36,7 +36,6 @@ MODULE_DESCRIPTION("ISDN4Linux: Driver for HYSDN cards"); 
MODULE_AUTHOR("Werner Cornelius");

MODULE_LICENSE("GPL");



static char *hysdn_init_revision = "$Revision: 1.6.6.6 $";

static int cardmax;		/* number of found cards */

hysdn_card *card_root = NULL;	/* pointer to first card */

static hysdn_card *card_last = NULL;	/* pointer to first card */
@@ -49,25 +48,6 @@ static hysdn_card *card_last = NULL; /* pointer to first card */ 
/* Additionally newer versions may be activated without rebooting.          */

/****************************************************************************/



/******************************************************/

/* extract revision number from string for log output */

/******************************************************/

char *

hysdn_getrev(const char *revision)

{

	char *rev;

	char *p;



	if ((p = strchr(revision, ':'))) {

		rev = p + 2;

		p = strchr(rev, '$');

		*--p = 0;

	} else

		rev = "???";

	return rev;

}





/****************************************************************************/

/* init_module is called once when the module is loaded to do all necessary */

/* things like autodetect...                                                */
@@ -175,13 +155,9 @@ static int hysdn_have_procfs; 
static int __init

hysdn_init(void)

{

	char tmp[50];

	int rc;



	strcpy(tmp, hysdn_init_revision);

	printk(KERN_NOTICE "HYSDN: module Rev: %s loaded\n", hysdn_getrev(tmp));

	strcpy(tmp, hysdn_net_revision);

	printk(KERN_NOTICE "HYSDN: network interface Rev: %s \n", hysdn_getrev(tmp));

	printk(KERN_NOTICE "HYSDN: module loaded\n");



	rc = pci_register_driver(&hysdn_pci_driver);

	if (rc)

drivers/isdn/hysdn/hysdn_net.c

+0 −3
Original line number Diff line number Diff line
@@ -26,9 +26,6 @@ 
unsigned int hynet_enable = 0xffffffff; 

module_param(hynet_enable, uint, 0);



/* store the actual version for log reporting */

char *hysdn_net_revision = "$Revision: 1.8.6.4 $";



#define MAX_SKB_BUFFERS 20	/* number of buffers for keeping TX-data */



/****************************************************************************/

drivers/isdn/hysdn/hysdn_procconf.c

+1 −2
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ 
#include "hysdn_defs.h"



static DEFINE_MUTEX(hysdn_conf_mutex);

static char *hysdn_procconf_revision = "$Revision: 1.8.6.4 $";



#define INFO_OUT_LEN 80		/* length of info line including lf */
@@ -404,7 +403,7 @@ hysdn_procconf_init(void) 
		card = card->next;	/* next entry */

	}



	printk(KERN_NOTICE "HYSDN: procfs Rev. %s initialised\n", hysdn_getrev(hysdn_procconf_revision));

	printk(KERN_NOTICE "HYSDN: procfs initialised\n");

	return (0);

}				/* hysdn_procconf_init */