Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cca8482c authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Fix buildid processing 



After recording, 'perf record' post-processes the data to determine
which buildids are needed.

That processing must process the data in time order, if possible,
because otherwise dependent events, like forks and mmaps, will not make
sense.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Tested-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1439994561-27436-4-git-send-email-adrian.hunter@intel.com


[ Moved the sample_id_add to after trying to open the events, use pr_warning ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 5cb73340

tools/perf/builtin-record.c

+11 −0
Original line number Diff line number Diff line
@@ -521,6 +521,15 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) 
		goto out_child;

	}



	/*

	 * Normally perf_session__new would do this, but it doesn't have the

	 * evlist.

	 */

	if (rec->tool.ordered_events && !perf_evlist__sample_id_all(rec->evlist)) {

		pr_warning("WARNING: No sample_id_all support, falling back to unordered processing\n");

		rec->tool.ordered_events = false;

	}



	if (!rec->evlist->nr_groups)

		perf_header__clear_feat(&session->header, HEADER_GROUP_DESC);
@@ -965,9 +974,11 @@ static struct record record = { 
	.tool = {

		.sample		= process_sample_event,

		.fork		= perf_event__process_fork,

		.exit		= perf_event__process_exit,

		.comm		= perf_event__process_comm,

		.mmap		= perf_event__process_mmap,

		.mmap2		= perf_event__process_mmap2,

		.ordered_events	= true,

	},

};