Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc90cb3b authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by David S. Miller
Browse files

net:phy:marvell: remove unnecessary code 



Compile tested.
remove unnecessary code that matches this coccinelle pattern

	ret = phy_write(x, y , z)
	if (ret < 0)
	       	return ret;
	return 0;

As phy_write returns error code, we dont need to do not need extra check
before returning.

Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@st.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8bc47ec6

drivers/net/phy/marvell.c

+3 −15
Original line number Diff line number Diff line
@@ -455,11 +455,7 @@ static int m88e1111_config_init(struct phy_device *phydev) 
	if (err < 0)

		return err;



	err = phy_write(phydev, MII_BMCR, BMCR_RESET);

	if (err < 0)

		return err;



	return 0;

	return phy_write(phydev, MII_BMCR, BMCR_RESET);

}



static int m88e1118_config_aneg(struct phy_device *phydev)
@@ -515,11 +511,7 @@ static int m88e1118_config_init(struct phy_device *phydev) 
	if (err < 0)

		return err;



	err = phy_write(phydev, MII_BMCR, BMCR_RESET);

	if (err < 0)

		return err;



	return 0;

	return phy_write(phydev, MII_BMCR, BMCR_RESET);

}



static int m88e1149_config_init(struct phy_device *phydev)
@@ -545,11 +537,7 @@ static int m88e1149_config_init(struct phy_device *phydev) 
	if (err < 0)

		return err;



	err = phy_write(phydev, MII_BMCR, BMCR_RESET);

	if (err < 0)

		return err;



	return 0;

	return phy_write(phydev, MII_BMCR, BMCR_RESET);

}



static int m88e1145_config_init(struct phy_device *phydev)