Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc70b080 authored by Mitch Williams's avatar Mitch Williams Committed by Jeff Kirsher
Browse files

i40evf: fix off-by-one 



The loop in i40evf_get_rxfh_indir was only reading fifteen registers,
not all sixteen. Change the matching loop in i40evf_set_rxfh_indir at
the same time to make the code more consistent.

Change-ID: I6c182287698e742d1f6ca1a4bcc43cc08df6e1de
Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent e57a2fea

drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -632,7 +632,7 @@ static int i40evf_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key) 
	u32 hlut_val;

	int i, j;



	for (i = 0, j = 0; i < I40E_VFQF_HLUT_MAX_INDEX; i++) {

	for (i = 0, j = 0; i <= I40E_VFQF_HLUT_MAX_INDEX; i++) {

		hlut_val = rd32(hw, I40E_VFQF_HLUT(i));

		indir[j++] = hlut_val & 0xff;

		indir[j++] = (hlut_val >> 8) & 0xff;
@@ -659,7 +659,7 @@ static int i40evf_set_rxfh(struct net_device *netdev, const u32 *indir, 
	u32 hlut_val;

	int i, j;



	for (i = 0, j = 0; i < I40E_VFQF_HLUT_MAX_INDEX + 1; i++) {

	for (i = 0, j = 0; i <= I40E_VFQF_HLUT_MAX_INDEX; i++) {

		hlut_val = indir[j++];

		hlut_val |= indir[j++] << 8;

		hlut_val |= indir[j++] << 16;