Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cbe5843e authored by Thomas Gardner's avatar Thomas Gardner Committed by Greg Kroah-Hartman
Browse files

staging: typec: Fix endianness warning discovered by sparse 



The below warning is resolved by removing the cpu_to_le32() call. This
call was redundant; vdm_run_state_machine() ensures that SVDM responses
have the correct endianness before sending.

typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types)
typec/tcpm.c:1019:49:    expected unsigned int [unsigned] [usertype] <noident>
typec/tcpm.c:1019:49:    got restricted __le32 [usertype] <noident>

Signed-off-by: default avatarThomas Gardner <tmg@fastmail.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 948d7048

drivers/staging/typec/tcpm.c

+1 −2
Original line number Diff line number Diff line
@@ -1015,8 +1015,7 @@ static int tcpm_pd_svdm(struct tcpm_port *port, const __le32 *payload, int cnt, 
			if (port->data_role == TYPEC_DEVICE &&

			    port->nr_snk_vdo) {

				for (i = 0; i <  port->nr_snk_vdo; i++)

					response[i + 1]

						= cpu_to_le32(port->snk_vdo[i]);

					response[i + 1] = port->snk_vdo[i];

				rlen = port->nr_snk_vdo + 1;

			}

			break;