Commit cbbf7d80 authored Nov 28, 2023 by Claudiu Beznea Committed by Greg Kroah-Hartman Dec 08, 2023

net: ravb: Start TX queues after HW initialization succeeded



[ Upstream commit 6f32c086602050fc11157adeafaa1c1eb393f0af ]

ravb_phy_start() may fail. If that happens, the TX queues will remain
started. Thus, move the netif_tx_start_all_queues() after PHY is
successfully initialized.

Fixes: c156633f ("Renesas Ethernet AVB driver proper")
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b655af79

drivers/net/ethernet/renesas/ravb_main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1392,13 +1392,13 @@ static int ravb_open(struct net_device *ndev)
		if (priv->chip_id == RCAR_GEN2)
		ravb_ptp_init(ndev, priv->pdev);

		netif_tx_start_all_queues(ndev);

		/* PHY control start */
		error = ravb_phy_start(ndev);
		if (error)
		goto out_ptp_stop;

		netif_tx_start_all_queues(ndev);

		return 0;

		out_ptp_stop: