Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb7386d3 authored by Brenden Blanco's avatar Brenden Blanco Committed by David S. Miller
Browse files

net/mlx4_en: use READ_ONCE when freeing xdp_prog 



For consistency, and in order to hint at the synchronous nature of the
xdp_prog field, use READ_ONCE in the destroy path of the ring. All
occurrences should now use either READ_ONCE or xchg.

Signed-off-by: default avatarBrenden Blanco <bblanco@plumgrid.com>
Acked-by: default avatarAlexei Starovoitov <ast@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f67fe5c8

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+4 −2
Original line number Diff line number Diff line
@@ -535,9 +535,11 @@ void mlx4_en_destroy_rx_ring(struct mlx4_en_priv *priv, 
{

	struct mlx4_en_dev *mdev = priv->mdev;

	struct mlx4_en_rx_ring *ring = *pring;

	struct bpf_prog *old_prog;



	if (ring->xdp_prog)

		bpf_prog_put(ring->xdp_prog);

	old_prog = READ_ONCE(ring->xdp_prog);

	if (old_prog)

		bpf_prog_put(old_prog);

	mlx4_free_hwq_res(mdev->dev, &ring->wqres, size * stride + TXBB_SIZE);

	vfree(ring->rx_info);

	ring->rx_info = NULL;