Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb716165 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] s5c73m3: fix subdev type 



This sensor driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, creating
some subdevs with a non-existing type.

As this is a sensor driver, one of the entries is
MEDIA_ENT_T_CAM_SENSOR. The other one will be using
MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN, because the subdev is not
any of the already existing types.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 59ecd59d

drivers/media/i2c/s5c73m3/s5c73m3-core.c

+2 −2
Original line number Diff line number Diff line
@@ -1688,7 +1688,7 @@ static int s5c73m3_probe(struct i2c_client *client, 


	state->sensor_pads[S5C73M3_JPEG_PAD].flags = MEDIA_PAD_FL_SOURCE;

	state->sensor_pads[S5C73M3_ISP_PAD].flags = MEDIA_PAD_FL_SOURCE;

	sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV;

	sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR;



	ret = media_entity_init(&sd->entity, S5C73M3_NUM_PADS,

							state->sensor_pads);
@@ -1704,7 +1704,7 @@ static int s5c73m3_probe(struct i2c_client *client, 
	state->oif_pads[OIF_ISP_PAD].flags = MEDIA_PAD_FL_SINK;

	state->oif_pads[OIF_JPEG_PAD].flags = MEDIA_PAD_FL_SINK;

	state->oif_pads[OIF_SOURCE_PAD].flags = MEDIA_PAD_FL_SOURCE;

	oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV;

	oif_sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN;



	ret = media_entity_init(&oif_sd->entity, OIF_NUM_PADS,

							state->oif_pads);