Commit cb3f3378 authored Aug 05, 2016 by Konstantin Khlebnikov Committed by Arnaldo Carvalho de Melo Aug 09, 2016

perf probe: Fix module name matching

If module is "module" then dso->short_name is "[module]". Substring
comparing is't enough: "raid10" matches to "[raid1]". This patch also
checks terminating zero in module name.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Link: http://lkml.kernel.org/r/147039975648.715620.12985971832789032159.stgit@buzz

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 8e34189b

tools/perf/util/probe-event.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -170,8 +170,10 @@ static struct map kernel_get_module_map(const char module)
		module = "kernel";

		for (pos = maps__first(maps); pos; pos = map__next(pos)) {
		/* short_name is "[module]" */
		if (strncmp(pos->dso->short_name + 1, module,
		pos->dso->short_name_len - 2) == 0) {
		pos->dso->short_name_len - 2) == 0 &&
		module[pos->dso->short_name_len - 2] == '\0') {
		return pos;
		}
		}