Commit cb323213 authored Jan 12, 2016 by Vladis Dronov Committed by Johan Hovold Jan 25, 2016

USB: serial: visor: fix crash on detecting device without write_urbs



The visor driver crashes in clie_5_attach() when a specially crafted USB
device without bulk-out endpoint is detected. This fix adds a check that
the device has proper configuration expected by the driver.

Reported-by: Ralf Spenneberg <ralf@spenneberg.net>
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Fixes: cfb8da8f ("USB: visor: fix initialisation of UX50/TH55 devices")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>

parent cac9b50b

drivers/usb/serial/visor.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -602,8 +602,10 @@ static int clie_5_attach(struct usb_serial *serial)
		*/

		/* some sanity check */
		if (serial->num_ports < 2)
		return -1;
		if (serial->num_bulk_out < 2) {
		dev_err(&serial->interface->dev, "missing bulk out endpoints\n");
		return -ENODEV;
		}

		/* port 0 now uses the modified endpoint Address */
		port = serial->port[0];