Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb2513bb authored by Luciano Coelho's avatar Luciano Coelho Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: use debugfs_create_bool() for enable_scan_iteration_notif 



There is no need to implement the enable_scan_iteration_notif handling
explicitly and there's no reason not to export the current value.  So
use debugfs_create_bool() instead.

Signed-off-by: default avatarLuciano Coelho <luciano.coelho@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 2250fd94

drivers/net/wireless/iwlwifi/mvm/debugfs.c

+5 −23
Original line number Diff line number Diff line
@@ -1473,26 +1473,6 @@ iwl_dbgfs_prph_reg_write(struct iwl_mvm *mvm, char *buf, 
	return count;

}



static ssize_t iwl_dbgfs_enable_scan_iteration_notif_write(struct iwl_mvm *mvm,

							   char *buf,

							   size_t count,

							   loff_t *ppos)

{

	int val;



	mutex_lock(&mvm->mutex);



	if (kstrtoint(buf, 10, &val)) {

		mutex_unlock(&mvm->mutex);

		return -EINVAL;

	}



	mvm->scan_iter_notif_enabled = val;

	mutex_unlock(&mvm->mutex);



	return count;

}



MVM_DEBUGFS_READ_WRITE_FILE_OPS(prph_reg, 64);



/* Device wide debugfs entries */
@@ -1515,7 +1495,6 @@ MVM_DEBUGFS_READ_WRITE_FILE_OPS(scan_ant_rxchain, 8); 
MVM_DEBUGFS_READ_WRITE_FILE_OPS(d0i3_refs, 8);

MVM_DEBUGFS_READ_WRITE_FILE_OPS(fw_dbg_conf, 8);

MVM_DEBUGFS_WRITE_FILE_OPS(fw_dbg_collect, 8);

MVM_DEBUGFS_WRITE_FILE_OPS(enable_scan_iteration_notif, 8);



#ifdef CONFIG_IWLWIFI_BCAST_FILTERING

MVM_DEBUGFS_READ_WRITE_FILE_OPS(bcast_filters, 256);
@@ -1559,8 +1538,11 @@ int iwl_mvm_dbgfs_register(struct iwl_mvm *mvm, struct dentry *dbgfs_dir) 
	MVM_DEBUGFS_ADD_FILE(d0i3_refs, mvm->debugfs_dir, S_IRUSR | S_IWUSR);

	MVM_DEBUGFS_ADD_FILE(fw_dbg_conf, mvm->debugfs_dir, S_IRUSR | S_IWUSR);

	MVM_DEBUGFS_ADD_FILE(fw_dbg_collect, mvm->debugfs_dir, S_IWUSR);

	MVM_DEBUGFS_ADD_FILE(enable_scan_iteration_notif, mvm->debugfs_dir,

			     S_IWUSR);

	if (!debugfs_create_bool("enable_scan_iteration_notif",

				 S_IRUSR | S_IWUSR,

				 mvm->debugfs_dir,

				 &mvm->scan_iter_notif_enabled))

		goto err;



#ifdef CONFIG_IWLWIFI_BCAST_FILTERING

	if (mvm->fw->ucode_capa.flags & IWL_UCODE_TLV_FLAGS_BCAST_FILTERING) {

drivers/net/wireless/iwlwifi/mvm/mvm.h

+1 −1
Original line number Diff line number Diff line
@@ -688,7 +688,7 @@ struct iwl_mvm { 
	bool disable_power_off;

	bool disable_power_off_d3;



	bool scan_iter_notif_enabled;

	u32 scan_iter_notif_enabled; /* must be u32 for debugfs_create_bool */



	struct debugfs_blob_wrapper nvm_hw_blob;

	struct debugfs_blob_wrapper nvm_sw_blob;