Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cae7ca3d authored by Heiko Carstens's avatar Heiko Carstens Committed by David S. Miller
Browse files

[IPVS]: Use IP_VS_WAIT_WHILE when encessary. 



For architectures that don't have a volatile atomic_ts constructs like
while (atomic_read(&something)); might result in endless loops since a
barrier() is missing which forces the compiler to generate code that
actually reads memory contents.
Fix this in ipvs by using the IP_VS_WAIT_WHILE macro which resolves to
while (expr) { cpu_relax(); }
(why isn't this open coded btw?)

Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7f353bf2

net/ipv4/ipvs/ip_vs_ctl.c

+1 −1
Original line number Diff line number Diff line
@@ -908,7 +908,7 @@ ip_vs_edit_dest(struct ip_vs_service *svc, struct ip_vs_dest_user *udest) 
	write_lock_bh(&__ip_vs_svc_lock);



	/* Wait until all other svc users go away */

	while (atomic_read(&svc->usecnt) > 1) {};

	IP_VS_WAIT_WHILE(atomic_read(&svc->usecnt) > 1);



	/* call the update_service, because server weight may be changed */

	svc->scheduler->update_service(svc);