Commit cab5e127 authored Mar 27, 2014 by John Stultz Committed by Ingo Molnar Mar 28, 2014

time: Revert to calling clock_was_set_delayed() while in irq context



In commit 47a1b796 ("tick/timekeeping: Call
update_wall_time outside the jiffies lock"), we moved to calling
clock_was_set() due to the fact that we were no longer holding
the timekeeping or jiffies lock.

However, there is still the problem that clock_was_set()
triggers an IPI, which cannot be done from the timer's hard irq
context, and will generate WARN_ON warnings.

Apparently in my earlier testing, I'm guessing I didn't bump the
dmesg log level, so I somehow missed the WARN_ONs.

Thus we need to revert back to calling clock_was_set_delayed().

Signed-off-by: John Stultz <john.stultz@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1395963049-11923-1-git-send-email-john.stultz@linaro.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 75c5a52d

kernel/time/timekeeping.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1435,7 +1435,8 @@ void update_wall_time(void)
		out:
		raw_spin_unlock_irqrestore(&timekeeper_lock, flags);
		if (clock_set)
		clock_was_set();
		/* Have to call _delayed version, since in irq context*/
		clock_was_set_delayed();
		}

		/**