Commit ca3704c2 authored Apr 17, 2016 by Charles Keepax Committed by Dmitry Torokhov Apr 17, 2016

Input: arizona-haptic - don't assign input_dev parent

We shouldn't assign the parent device of the input_dev to be the
parent MFD device, because this will be used for devres which causes
input_unregister_device to run after the haptics device has been
removed, since it is itself a child of the MFD device. The default
of using the haptics device itself as the parent is correct.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 7eb5ca09

drivers/input/misc/arizona-haptics.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -178,7 +178,6 @@ static int arizona_haptics_probe(struct platform_device *pdev)
		input_set_drvdata(haptics->input_dev, haptics);

		haptics->input_dev->name = "arizona:haptics";
		haptics->input_dev->dev.parent = pdev->dev.parent;
		haptics->input_dev->close = arizona_haptics_close;
		__set_bit(FF_RUMBLE, haptics->input_dev->ffbit);