Commit c95d4bf1 authored Apr 21, 2022 by Christophe JAILLET Committed by Greg Kroah-Hartman May 12, 2022

bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create()



[ Upstream commit fff8c10368e64e7f8960f149375c12ca5f3b30af ]

This code is really spurious.
It always returns an ERR_PTR, even when err is known to be 0 and calls
put_device() after a successful device_register() call.

It is likely that the return statement in the normal path is missing.
Add 'return rdev;' to fix it.

Fixes: d787dcdb ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Tested-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/ef2b9576350bba4c8e05e669e9535e9e2a415763.1650551719.git.christophe.jaillet@wanadoo.fr


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent cc639aa3

drivers/bus/sunxi-rsb.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -224,6 +224,8 @@ static struct sunxi_rsb_device sunxi_rsb_device_create(struct sunxi_rsb rsb,

		dev_dbg(&rdev->dev, "device %s registered\n", dev_name(&rdev->dev));

		return rdev;

		err_device_add:
		put_device(&rdev->dev);