Commit c959acfd authored Jan 16, 2011 by Hans Verkuil Committed by Mauro Carvalho Chehab Jan 19, 2011

[media] v4l2-ctrls: fix missing 'read-only' check



VIDIOC_S_CTRL did not check against read-only controls. Even worse, for
controls of type CTRL_CLASS it would cause a kernel oops since those controls
do not have a s_ctrl op.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 4999e27a

drivers/media/video/v4l2-ctrls.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1824,6 +1824,9 @@ static int set_ctrl(struct v4l2_ctrl ctrl, s32 val)
		int ret;
		int i;

		if (ctrl->flags & V4L2_CTRL_FLAG_READ_ONLY)
		return -EACCES;

		v4l2_ctrl_lock(ctrl);

		/* Reset the 'is_new' flags of the cluster */