Commit c953d635 authored May 16, 2017 by Gao Feng Committed by Pablo Neira Ayuso May 16, 2017

ebtables: arpreply: Add the standard target sanity check



The info->target comes from userspace and it would be used directly.
So we need to add the sanity check to make sure it is a valid standard
target, although the ebtables tool has already checked it. Kernel needs
to validate anything coming from userspace.

If the target is set as an evil value, it would break the ebtables
and cause a panic. Because the non-standard target is treated as one
offset.

Now add one helper function ebt_invalid_target, and we would replace
the macro INVALID_TARGET later.

Signed-off-by: Gao Feng <gfree.wind@vip.163.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 59105446

include/linux/netfilter_bridge/ebtables.h

+5 −0

Original line number	Diff line number	Diff line
		@@ -125,4 +125,9 @@ extern unsigned int ebt_do_table(struct sk_buff *skb,
		/* True if the target is not a standard target */
		#define INVALID_TARGET (info->target < -NUM_STANDARD_TARGETS \|\| info->target >= 0)

		static inline bool ebt_invalid_target(int target)
		{
		return (target < -NUM_STANDARD_TARGETS \|\| target >= 0);
		}

		#endif

net/bridge/netfilter/ebt_arpreply.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -68,6 +68,9 @@ static int ebt_arpreply_tg_check(const struct xt_tgchk_param *par)
		if (e->ethproto != htons(ETH_P_ARP) \|\|
		e->invflags & EBT_IPROTO)
		return -EINVAL;
		if (ebt_invalid_target(info->target))
		return -EINVAL;

		return 0;
		}