Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8f33d0b authored by Sanidhya Kashyap's avatar Sanidhya Kashyap Committed by Linus Torvalds
Browse files

affs: kstrdup() memory handling 



There is a possibility of kstrdup() failure upon memory pressure.
Therefore, returning ENOMEM even for new_opts.

[akpm@linux-foundation.org: cleanup]
Signed-off-by: default avatarSanidhya Kashyap <sanidhya.gatech@gmail.com>
Cc: Taesoo kim <taesoo@gatech.edu>
Cc: Fabian Frederick <fabf@skynet.be>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 79bda4d5

fs/affs/super.c

+5 −1
Original line number Diff line number Diff line
@@ -521,10 +521,14 @@ affs_remount(struct super_block *sb, int *flags, char *data) 
	int			 root_block;

	unsigned long		 mount_flags;

	int			 res = 0;

	char			*new_opts = kstrdup(data, GFP_KERNEL);

	char			*new_opts;

	char			 volume[32];

	char			*prefix = NULL;



	new_opts = kstrdup(data, GFP_KERNEL);

	if (!new_opts)

		return -ENOMEM;



	pr_debug("%s(flags=0x%x,opts=\"%s\")\n", __func__, *flags, data);



	sync_filesystem(sb);