Commit c8eecd65 authored Mar 25, 2019 by Kangjie Lu Committed by Greg Kroah-Hartman May 31, 2019

thunderbolt: property: Fix a missing check of kzalloc



[ Upstream commit 6183d5a51866f3acdeeb66b75e87d44025b01a55 ]

No check is enforced for the return value of kzalloc,
which may lead to NULL-pointer dereference.

The patch fixes this issue.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1de8f965

drivers/thunderbolt/property.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -581,7 +581,12 @@ int tb_property_add_text(struct tb_property_dir parent, const char key,
		return -ENOMEM;

		property->length = size / 4;
		property->value.data = kzalloc(size, GFP_KERNEL);
		property->value.text = kzalloc(size, GFP_KERNEL);
		if (!property->value.text) {
		kfree(property);
		return -ENOMEM;
		}

		strcpy(property->value.text, text);

		list_add_tail(&property->list, &parent->properties);