Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7ac86de authored by Bryn M. Reeves's avatar Bryn M. Reeves Committed by Alasdair G Kergon
Browse files

dm mpath: rdac fix init race 



Re-order the initialisation of dm-rdac to avoid registering the hw
handler before the workqueue has been initialised. Closes a race
that would potentially give an oops.

Signed-off-by: default avatarBryn M. Reeves <breeves@redhat.com>
Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
parent 60812a4a

drivers/md/dm-mpath-rdac.c

+8 −7
Original line number Diff line number Diff line
@@ -664,20 +664,21 @@ static struct hw_handler_type rdac_handler = { 


static int __init rdac_init(void)

{

	int r = dm_register_hw_handler(&rdac_handler);



	if (r < 0) {

		DMERR("%s: register failed %d", RDAC_DM_HWH_NAME, r);

		return r;

	}

	int r;



	rdac_wkqd = create_singlethread_workqueue("rdac_wkqd");

	if (!rdac_wkqd) {

		DMERR("Failed to create workqueue rdac_wkqd.");

		dm_unregister_hw_handler(&rdac_handler);

		return -ENOMEM;

	}



	r = dm_register_hw_handler(&rdac_handler);

	if (r < 0) {

		DMERR("%s: register failed %d", RDAC_DM_HWH_NAME, r);

		destroy_workqueue(rdac_wkqd);

		return r;

	}



	DMINFO("%s: version %s loaded", RDAC_DM_HWH_NAME, RDAC_DM_HWH_VER);

	return 0;

}