Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c79d92bd authored by Badhri Jagan Sridharan's avatar Badhri Jagan Sridharan Committed by Greg Kroah-Hartman
Browse files

staging: typec: tcpm: Check cc status before entering SRC_TRY_DEBOUCE 



[  130.893355] state change SNK_DEBOUNCED -> SRC_TRY
[  130.893363] cc:=3
[  130.893490] pending state change SRC_TRY -> SNK_TRYWAIT @ 100 ms
[  130.895602] CC1: 3 -> 0, CC2: 0 -> 0 [state SRC_TRY, polarity 0, disconnected]
[  130.895613] state change SRC_TRY -> SRC_TRY_DEBOUNCE
[  130.895621] pending state change SRC_TRY_DEBOUNCE -> SRC_ATTACHED @ 20 ms
[  130.916843] state change SRC_TRY_DEBOUNCE -> SRC_ATTACHED [delayed 20 ms]

Although the CC state was changing to TYPEC_CC_OPEN, the port entered
SRC_TRY_DEBOUNCE from SRC_TRY. The port must enter SRC_TRY_DEBOUNCE only
if the CC state is TYPEC_CC_RD.

Signed-off-by: default avatarBadhri Jagan Sridharan <Badhri@google.com>
[groeck: Wording]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b17dd571

drivers/staging/typec/tcpm.c

+2 −1
Original line number Diff line number Diff line
@@ -2897,6 +2897,7 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1, 
		break;



	case SRC_TRY:

		if (tcpm_port_is_source(port))

			tcpm_set_state(port, SRC_TRY_DEBOUNCE, 0);

		break;

	case SRC_TRY_DEBOUNCE: